feat(UI): issue main page rebuild&add pagination component#1103
Merged
benjamin-747 merged 2 commits intoJun 10, 2025
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
A PR that rebuilds the issue main page UI and adds a new pagination component.
- Replace the legacy IssuePage with the new IssueIndex component.
- Introduce ScopeProvider wrapping to enhance context handling.
- Add a new pagination component and update several related UI files.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| moon/apps/web/pages/[org]/issue/index.tsx | Replaces IssuePage with IssueIndex and wraps AppLayout with ScopeProvider. |
| moon/apps/web/components/Titlebar/BreadcrumbPageIcons.tsx | Adds a new IssueBreadcrumbIcon component using QuestionMarkCircleIcon. |
| moon/apps/web/components/Issues/utils/store.tsx | Introduces state atoms for issue filtering, sorting, darkMode, and currentPage. |
| moon/apps/web/components/Issues/utils/getPages.ts | Adds helper function for pagination calculations. |
| moon/apps/web/components/Issues/Pagenation.tsx | Implements the Pagination component using getPages and BreadcrumbTitlebar. |
| moon/apps/web/components/Issues/NewIssueButton.tsx | Adds a button for creating a new note/issue with conditional behavior. |
| moon/apps/web/components/Issues/IssuesContent.tsx | Provides logic for fetching and displaying issues with pagination and empty state handles. |
| moon/apps/web/components/Issues/IssuePage.tsx | Updates UI styling and button variants as part of the issue page rebuild. |
| moon/apps/web/components/Issues/IssueNewPage.tsx | Enhances the new issue page with title enhancements and updated submit button. |
| moon/apps/web/components/Issues/IssueList.tsx | Implements rendering of issue list items using new props and icons. |
| moon/apps/web/components/Issues/IssueIndex.tsx | Reworks the issue index layout and integrates the new IssueIndexTabFilter and NewIssueButton. |
| moon/apps/web/components/IndexPages/components.tsx | Updates loading components to include an instant loading spinner. |
Comments suppressed due to low confidence (2)
moon/apps/web/components/Issues/NewIssueButton.tsx:10
- The component is named 'NewNoteButton' but is expected to act as a new issue button. Consider renaming it to 'NewIssueButton' for consistency between file naming and its usage in IssueIndex.
export function NewNoteButton({ size = 'base' }: { size?: ButtonProps['size'] }) {
moon/apps/web/components/Issues/IssuesContent.tsx:96
- [nitpick] The prop name 'searchIssuList' appears to be a typo; consider renaming it to 'searchIssueList' to improve readability and consistency.
<IssueSearchList searchIssuList={issueList} />
liuyangjuncong20202570
force-pushed
the
feat/issue-rebuild
branch
from
June 10, 2025 08:32
8ba070e to
4fc7cf0
Compare
liuyangjuncong20202570
force-pushed
the
feat/issue-rebuild
branch
from
June 10, 2025 08:53
4fc7cf0 to
420f2a8
Compare
benjamin-747
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
增加：
issue主页面相关组件
封装pagination组件